Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give an error when a file type is used in a global using static #62258

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Give an error when a file type is used in a global using static #62258

merged 1 commit into from
Jun 30, 2022

Conversation

RikkiGibson
Copy link
Contributor

Related to #60819

@RikkiGibson RikkiGibson requested a review from a team as a code owner June 29, 2022 22:59
RikkiGibson
RikkiGibson commented Jun 29, 2022
View reviewed changes
src/Compilers/CSharp/Test/Symbol/Symbols/Source/FileModifierTests.cs
}

[Fact]
public void GlobalUsingStatic_02()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that "regular" UsingStatic tests are already present in this file.

jcouv
jcouv approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jun 29, 2022
@RikkiGibson RikkiGibson merged commit 332fa0a into dotnet:features/file-types Jun 30, 2022
@RikkiGibson RikkiGibson deleted the ft-global-using branch June 30, 2022 00:31
@ryzngard ryzngard mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RikkiGibson @cston @jcouv